Changeset 61855eb in OpenSC

Timestamp:

06/11/11 07:33:30 (12 months ago)

Author:

Peter Marschall <peter@…>

Branches:

master, staging

Children:

1c437c04

Parents:

291ec6b

git-author:

Peter Marschall <peter@…> (06/02/11 14:19:38)

git-committer:

Peter Marschall <peter@…> (06/11/11 07:33:30)

Message:

opensc-explorer: remove unnecessary var's in do_update_*()

The variables "in_str" in do_update_binary() & do_update_record()
do not serve a purpose: use argv[x] directly & remove them.

Signed-off-by: Peter Marschall <peter@…>

File:

• src/tools/opensc-explorer.c (modified) (5 diffs)

src/tools/opensc-explorer.c

@@ -1100 +1100 @@
         sc_path_t path;
         sc_file_t *file;
-        char *in_str;
 
         if (argc != 3)
@@ -1108 +1107 @@
         offs = strtol(argv[1],NULL,10);
 
-        in_str = argv[2];
-        printf("in: %i; %s\n", offs, in_str);
-
-        r = parse_string_or_hexdata(in_str, buf, &buflen);
+        printf("in: %i; %s\n", offs, argv[2]);
+
+        r = parse_string_or_hexdata(argv[2], buf, &buflen);
         if (r < 0) {
                 printf("unable to parse data\n");
@@ -1152 +1150 @@
         sc_path_t path;
         sc_file_t *file;
-        char *in_str;
 
         if (argc != 4)
@@ -1161 +1158 @@
         offs = strtol(argv[2],NULL,10);
 
-        in_str = argv[3];
-        printf("in: %i; %i; %s\n", rec, offs, in_str);
+        printf("in: %i; %i; %s\n", rec, offs, argv[3]);
 
         r = sc_select_file(card, &path, &file);
@@ -1185 +1181 @@
 
         buflen = sizeof(buf) - offs;
-        i = parse_string_or_hexdata(in_str, buf + offs, &buflen);
+        i = parse_string_or_hexdata(argv[3], buf + offs, &buflen);
         if (!i) {
                 printf("unable to parse data\n");